V-AS / Two-tower-recommender-system

MIT License
0 stars 0 forks source link

MIS MG Review #2 #18

Closed Yuanqi-X closed 1 month ago

Yuanqi-X commented 1 month ago

For Section 4 (Notation) of the MIS, it might be beneficial to include "String" as a derived data type, as it is used frequently for inputs and outputs in later sections. Additionally, "TrainingConfig" and "LayerConfig" appear as variable types but do not seem to be listed as data types or documented elsewhere in the MIS. It might be helpful to either define them as predefined notations or include them explicitly in this section for clarity. Also, since a tuple-like notation (e.g., [(Z, R)]) is used, such as in the output of the search function in Section 12, it may be beneficial to include a brief explanation of this notation in the Notation section as well.

V-AS commented 1 month ago

see commit 62c0f08fcc7f92887016aeb634b15b6e7793a360