search

V-AS / Two-tower-recommender-system

MIT License
0 stars 0 forks source link

MIS MG Review #4 #20

Closed Yuanqi-X closed 1 month ago

Yuanqi-X commented 1 month ago

It appears that two local functions are defined in the MIS: compute_loss in Section 8 and rank_candidates in Section 10. Currently, compute_loss only specifies the types of its inputs, while rank_candidates includes type declarations for both inputs and output. For consistency, it might be beneficial to include both input and output type declarations for both local functions.

V-AS commented 1 month ago

Updated the local function definitions for both compute_loss and rank_candidates to include consistent type declarations for inputs and outputs.(Commit: 51e9385ee64183b85093d1928ef3424c8759c587)