search

V-AS / Two-tower-recommender-system

MIT License
0 stars 0 forks source link

MIS MG Review #5 #21

Closed Yuanqi-X closed 1 month ago

Yuanqi-X commented 1 month ago

In Section 11 (MIS of the Neural Network Architecture Module), it seems that the module is intended to use the VectorOperations Module. However, in the Use Hierarchy Figure of MG, the Neural Network Architecture Module is not shown as using any other module. Could this be an oversight in the MIS? Based on the overall structure, it actually makes more sense to me that this module does not depend on any others.

V-AS commented 1 month ago

Thanks for pointing that out. The actual implementation in neural_network.py does not import vector_operations. I have updated the Uses section for the Neural Network Architecture Module to indicate that it does not use any other modules. (Commit: 51e9385ee64183b85093d1928ef3424c8759c587)