V-AS / Two-tower-recommender-system

MIT License
0 stars 0 forks source link

MG & MIS feedback #3 from Dr. Smith #24

Closed V-AS closed 1 month ago

V-AS commented 1 month ago

Section 10: The local function is not used in the specification.

Section 13: Is the dot product the only vector operation? What is Len()?

V-AS commented 1 month ago

I have updated Section 10. The get_recommendation function now returns a ranked list of items. The items in the list are ranked based on the results of the local function rank_candidates.

Yes, the dot product is the only vector operation. Other vector operations used during training are built-in functions provided by PyTorch.

Please remove the Len() function.

See the commit b3360c18fbc69895e2156de6beeffb04c890721e