search

V-Sekai / godot-whisper

An GDExtension addon for the Godot Engine that enables realtime audio transcription, supports OpenCL for most platforms, Metal for Apple devices, and runs on a separate thread.
MIT License
65 stars 6 forks source link

Use godot `thread` #35

Closed aiaimimi0920 closed 9 months ago

aiaimimi0920 commented 9 months ago

After debugging, I found that it was because of using MutexLock lock(s_mutex); is not unlocked correctly, causing the final thread to freeze.

If you use s_mutex.lock() and s_mutex.unlock() there will be no problem

fire commented 9 months ago

Did something break on the cicd?

fire commented 9 months ago

I'll merge it once it passes on your cicd. image

aiaimimi0920 commented 9 months ago

@fire It has been compiled and passed. This is a local windows test.

https://github.com/V-Sekai/godot-whisper/assets/153103332/865f9eaa-4952-4925-a2d4-f8dad6260bdb

fire commented 9 months ago

Thanks

Ughuuu commented 9 months ago

It's strange that the cicd doesn't start for his pr's. Maybe we need to set up some option. I'll check