Migrate banners component from WDKClient

VEuPathDB / CoreUI

Core UI for VeuPathDB applications. Provides components, style definitions, and utilities to enable developers to rapidly assemble complex applications with consistent UI and UX across our portfolio of sites.

1 stars 0 forks source link

Migrate banners component from WDKClient #60

Closed jernestmyers closed 2 years ago

jernestmyers commented 2 years ago

Relates to issue #59.

Current iteration has done the following:

Refactor the Banner component to be a functional component and to include TypeScript
Replace the SASS stylesheet with @emotion/react styling
Add stories for each type of banner (warning, error, info, etc.)
Attempt to match the existing WDKClient banners' palettes with those in CoreUI

Open questions:

Which icons should we use? Currently pulling from Material-UI, but the difference between the icons for "info" and "error" is almost indistinguishable.
Should each banner type be its own component, like WarningBanner, InfoBanner, etc?

jernestmyers commented 2 years ago

BannerList is used in FavoritesList and behaves as expected when imported from the new component in CoreUI. The style issue with the "Undo" button was handled in the FavoritesList component. Screenshots below show a comparison of FavoritesList.

Existing FavoritesList that uses BannerList from WDKClient:

Proposed FavoritesList that uses BannerList from CoreUI: