search

VEuPathDB / web-components

Library of React components for plotting data
Apache License 2.0
1 stars 0 forks source link

change prop name #433

Closed moontrip closed 1 year ago

moontrip commented 1 year ago

Following @bobular's suggestion on https://github.com/VEuPathDB/web-eda/pull/1494#issuecomment-1357876861, the prop name is changed to markerBodyOpacity.

moontrip commented 1 year ago

@jernestmyers Thank you for finding a bug. 👍 I just committed a fix. So the bug will not happen if the corresponding web-eda work (https://github.com/VEuPathDB/web-eda/pull/1494) will be merged. But since a marker opacity work at web-components was already merged, a logic to compute marker.line.width causes an issue without the web-eda PR. I have added to identify such an edge case so that the marker opacity works without the web-eda PR.

If this is approved, then I will make version up PR at web-eda, then it would work fine at web-eda main branch: I have checked with npm-pack-here

moontrip commented 1 year ago

This looks to resolve the missing markers in my analyses' scatterplots. image

@jernestmyers Thank you for your confirmation! 🥳