VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

2x2 Mosaic: update parameter selection frontend to allow users to select reference groups for all variables #1575

Closed danicahelb closed 1 year ago

danicahelb commented 1 year ago

Related to https://github.com/VEuPathDB/EdaDataService/issues/130

Final parameter selection UI can be found here: https://www.figma.com/file/Su1eNm3Bby85CfrnX42L7q/2x2-table-UI?node-id=44%3A431&t=ZCxlWaPOOG1AbgKr-0

danicahelb commented 1 year ago
image
nkittur-uga commented 1 year ago

I keep running into this bug while trying to do this:

Screenshot 2023-02-22 at 12 10 43 PM
nkittur-uga commented 1 year ago

Also, I noticed that value selection is only available (enabled) after both X and Y variables have been selected. It left me wondering for a second why the X value selection was not available after I selected the X var.

Screenshot 2023-02-22 at 12 10 13 PM
jernestmyers commented 1 year ago

This is currently only testable on a dev site due to the backend changes. Actually, I would expect this to work on QA. It does work fine on my dev site with latest code.

Also, I noticed that value selection is only available (enabled) after both X and Y variables have been selected. It left me wondering for a second why the X value selection was not available after I selected the X var.

I initially implemented this along the lines of your thinking, but then I interpreted the mockups to enable those buttons only after table vars are selected.

nkittur-uga commented 1 year ago

Thanks for the clarification. Yes, I would interpret the mockups as you did. I'll mention this to my team just to make sure everyone likes having it this way.

nkittur-uga commented 1 year ago

@jernestmyers - I spoke to the team and we feel that the Quadrant A values should become active immediately after their corresponding x- or y-axis variable has been selected. Sorry this is different from the mock-ups! And thank you for making the update.

jernestmyers commented 1 year ago

I've merged changes to get the disable/enable behavior to work as requested. The QA site's backend is having trouble getting up-to-date with the client code, but in the meantime things can be viewed/tested on my dev site.

nkittur-uga commented 1 year ago

Looks great, thanks Jeremy!