search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Disable steps in computed vars until data/configuration exists #1577

Closed jernestmyers closed 1 year ago

jernestmyers commented 1 year ago

Resolves https://github.com/VEuPathDB/web-eda/issues/1559

asizemore commented 1 year ago

Not sure if this should be a separate ticket, but sometimes it looks like the config selectors changing makes the visualization try to update. So below, i made a new ranked abundance box, selected my app config, then got this screen

Screen Shot 2023-01-26 at 2 58 33 PM

Sometimes this happens if i have already made a plot, and then go change config values. So here i had a fully working plot with Data: Phylum. I changed to this metagenomic parameter, and saw the following.

Screen Shot 2023-01-26 at 3 05 04 PM

I switched the param back to Phylum, all works. I go back again to that metagenomic one, and now the job is complete and i can use the plot!

Screen Shot 2023-01-26 at 3 06 39 PM

So i think what's happening is the config changing is autostarting a job, and the viz is looking for that data. If i go back again to that config, the compute job has finished so it's all there!

I'd guess for sake of storage space we wouldn't want to autostart a job when the config changes.

Anyways, might be a separate issue but logging it here to start!

jernestmyers commented 1 year ago

Ah, yes. That's a problem. Thanks for detailed examples and steps to re-create. I'll dig into it now.

jernestmyers commented 1 year ago

Removing this logic and conditional rendering for job status appeared to be the culprit.

I've more or less reverted back to where we use plot SVGs based on the job status.

image