search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Display error messaging in download modal #1588

Closed jernestmyers closed 1 year ago

jernestmyers commented 1 year ago

Resolves #1522

Displays a rudimentary message informing user of data fetching error. The error response expected in this component differed from what is currently being received. An error modal is being rendered as a result of this mismatch, but it appears behind the download modal. Instead, I've rendered the error in the download modal itself though it may be preferred to render it differently in terms of location, styling, and/or messaging.

Before (image 1 shows blank space where data grid is expected and one can faintly see the error modal behind the download modal; image 2 shows the error modal when the download modal is closed): image image

After (notice there's no more error modal resulting from the JSON.parse() syntax error): image

asizemore commented 1 year ago

I definitely like having the error within the modal - great idea. I think it's just the table part that errs(?), but the download button should still work (just tested on feature). Can we move the messaging underneath the 2 View Table and Download? Then the Download button could still function, and it'd be more clear that it's just the viewing the table part that's erring.