search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

resolving lineplot binning with axis range #1623

Closed moontrip closed 1 year ago

moontrip commented 1 year ago

This will resolve https://github.com/VEuPathDB/web-eda/issues/1544. Note that since there existed banner control behavior-related PR (https://github.com/VEuPathDB/web-eda/pull/1589) that involves many changes, this PR is branched out from that PR (lineplot-banner-no-data branch). But if #1589 is approved and merged, then I will eventually update this PR to be merged into main branch later.

Tried various approaches, e.g., modifying onChangeHandlerFactory, etc., but arguably the current implementation is the simplest one we can resolve the issue. I didn't notice specific issue for both numeric and date xAxisvariable.

moontrip commented 1 year ago

@bobular Thank you for your detailed information 👍 As for the y-axis auto-range, if I remember correctly, it is the same behavior to other Vizs like Scatter and Lineplot Vizs: y-axis auto range does not consider x-axis range? For example, the difference between Full and Auto-zoom in the Scatterplot Viz's Y-axis range is that the former relies on backend's range/displayRange min/max while the latter is computed based on full data.

bobular commented 1 year ago

Thanks DK - sorry it was a long haul!

moontrip commented 1 year ago

@bobular No problem! Thank you for your kind attention on this matter 👍