VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Mosaic 2x2 banners #1636

Closed moontrip closed 1 year ago

moontrip commented 1 year ago

This will resolve https://github.com/VEuPathDB/web-eda/issues/1383 and https://github.com/VEuPathDB/web-eda/issues/1574. Screenshots are attached in the following:

a) showing top and stats table banners at once (unfolded) mosaic-2x2-banner00

b) showing top banner content after folded mosaic-2x2-banner01

c) showing stats table banner content after folded: no facet variable mosaic-2x2-banner02

d) a case with a facet variable (unfolded) mosaic-2x2-banner03

asizemore commented 1 year ago

I originally thought we should keep it the same, but that screenshot above changed my mind :) When we facet, that line underneath the tabs with Statistics widens, and also we can see that the banner above matches the width of that area of the page. For those reasons in addition to what @jernestmyers said, I'd vote to let the banner expand to fill that space.

moontrip commented 1 year ago

Thank you for your suggestions concerning the width of stats' table banner for the case of facet variable, @jernestmyers @asizemore Actually I was gauging whether it should be full width or not so your suggestion convinced me of making a decision. I will update it 👍

moontrip commented 1 year ago

Also, I think we should open a follow-up ticket in CoreUI to change the cursor of the collapsibleIcon to be pointer, which would better indicate that it's a clickable button.

Here's the relevant code in the Banner component.

Definitely I like the idea @jernestmyers: I was thinking the case before but didn't have time to do that. Perhaps you can easily handle it at a follow-up ticket in the near future 😄

jernestmyers commented 1 year ago

Definitely I like the idea @jernestmyers: I was thinking the case before but didn't have time to do that. Perhaps you can easily handle it at a follow-up ticket in the near future 😄

Yes, I'll open the issue now and try to get to it soon!

moontrip commented 1 year ago

@jernestmyers @asizemore As suggested, I made a full width of stats table banner when a facet variable exists. Here is a screenshot:

mosaic-2x2-banner04