VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

handle "expired" jobs by allowing the user to resubmit #1637

Closed asizemore closed 1 year ago

asizemore commented 1 year ago

Finally hit an expired job!!! Confirmed with the backend band that the expired jobs are intended to be rerun by the user. Let's allow them to do this!

I'd propose the status indicator is gray again, and the text is "Results have expired. Please regenerate the results."

Screen Shot 2023-02-22 at 11 00 59 AM
asizemore commented 1 year ago

for qa, please test the example given above! see if we can now regenerate results!

asizemore commented 1 year ago
Screen Shot 2023-02-27 at 5 33 36 AM

Found another example for testing!

asizemore commented 1 year ago

Requires the compute service >v1.3.2 for testing. I'll comment here when that version is ready!

SheenaTomko commented 1 year ago

@aaronwlsong, note that you will need to wait to qa this on qa.microbiomedb.org until Ann says the compute service is ready

asizemore commented 1 year ago

So far not looking good... the qa site got the new code but we're seeing this error. I sent it to Ryan and Ellie for their thoughts!

This is DIABIMMUNE, beta div, data=Species, method=bray.

Screen Shot 2023-02-28 at 4 03 21 PM
dmfalke commented 1 year ago

@asizemore is it possible https://github.com/VEuPathDB/web-eda/pull/1655 will address the latest issue?

asizemore commented 1 year ago

Unfortunately no, as it's in the backend. But Ellie has already made a PR to fix it so hopefully we'll see it all working shortly!

asizemore commented 1 year ago

All updated! Please go ahead with QA of this ticket

aaronwlsong commented 1 year ago

I tested both cases aforementioned. For the color of dot: Yes, now it is grey. For the text, instead of showing "Results have expired. Please regenerate the results." it shows as "Not started". Does not look like the same meaning for me. I will put it under "Failed QA" category. If the text part is an expected, I (or anyone else) can change the status to "Completed".

Case 1

Image

Case 2

Image

asizemore commented 1 year ago

That's great! The cache got cleared recently so we actually shouldn't be seeing "expired" for a bit :)

I have previously seen an expired job and when I clicked the button to rerun it worked, so i'll go ahead and move this to Complete. Thanks @aaronwlsong for looking into this!