search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

SAM histogram filter should not be in all caps #1683

Closed danicahelb closed 1 year ago

danicahelb commented 1 year ago

All-caps appeared in the SAM...

image

In clinepi it looks like this:

image
danicahelb commented 1 year ago

Please change all caps on SAM to sentence case to match EDA. Note that the variable label should start with a capital letter (and any other capitalization in the variable label should be maintained)

dmfalke commented 1 year ago

FYI, this is currently handled by using an mui <ThemeProvider>: https://github.com/VEuPathDB/web-eda/blob/cba2c65d46c01b69533c7f5793a2b56468df0815/src/lib/workspace/WorkspaceRouter.tsx#L153.

We need the same thing for the map. Perhaps we should have a common container component for both apps that incorporates this, and any other top-level components.

bobular commented 1 year ago

I was trying to figure out what was going on and also found this:

https://github.com/VEuPathDB/web-eda/blob/cba2c65d46c01b69533c7f5793a2b56468df0815/src/lib/workspace/WorkspaceContainer.tsx#L20-L24

Commenting it out brings back the all-caps.

However, I figured out to do it as part of the theme, in workspaceTheme.ts, woo hoo!

export const workspaceTheme: ThemeOptions = {
  typography: {
    fontSize: 13,
    fontFamily:
      'Roboto, "Helvetica Neue", Helvetica, "Segoe UI", Arial, freesans, sans-serif',
    button: {
      textTransform: 'none',
    },
  },

Is that preferable/more consistent?

dmfalke commented 1 year ago

This sounds good!

bobular commented 1 year ago

Is this related to https://github.com/VEuPathDB/web-monorepo/issues/28 ?