[x] T_... that we use _Interface or Interface for interface types Applied change: using _Interface
[x] T_... that we use something that is understood naturally without a secret decoder ring. Applied change: currently, there are no ordinary types in the packages, all are records defining an interface.
[x] V_... that we use _View or ViewApplied change: using _View
[x] For ..._In also consider In as suffix (w/o _).
"In" follows main data flow. Similar thoughts for ...Out
Like: I2C_InView vs. I2CViewIn vs. I2CView_In
No Like: I2CInView vs. I2C_In_View vs. I2C_View_In
Applied change: using _InView and _OutView respectively.
[x] For each interface there shall be a vector of that interface also declared of the form: _Interface_VectorApplied change: requirement was already fulfilled
[x] _PCB vs FPGA Internals
Applied change: PCB related signals use suffix _PCB, which fabric signal have no suffix.
[x] Review naming for AddressBus which historically was Master/Initiator and Slave/Target
Applied change: Different names chooses, if not dictated by the standard itself. If the standard changes naming, these definitions can be changed too.
[x] AxiAddress should be unsigned. Applied change: AXI is not part of this repo yet, will be applied when AXI is uploaded.
This PR addresses #10.
T_...
that we use_Interface
orInterface
for interface typesApplied change: using
_Interface
T_...
that we use something that is understood naturally without a secret decoder ring.Applied change: currently, there are no ordinary types in the packages, all are records defining an interface.
V_...
that we use_View
orView
Applied change: using_View
[x] For
..._In
also consider In as suffix (w/o _)."In" follows main data flow. Similar thoughts for ...Out
I2C_InView
vs.I2CViewIn
vs.I2CView_In
I2CInView
vs.I2C_In_View
vs.I2C_View_In
Applied change: using
_InView
and_OutView
respectively._Interface_Vector
Applied change: requirement was already fulfilled_PCB
vs FPGA Internals Applied change: PCB related signals use suffix_PCB
, which fabric signal have no suffix.Applied change: AXI is not part of this repo yet, will be applied when AXI is uploaded.
/cc @JimLewis see changes