VNG-Realisatie / api-test-platform

6 stars 3 forks source link

Provider postman run: Incorrect HTML-log output? #241

Closed alextreme closed 5 years ago

alextreme commented 5 years ago

Bug

Raised by @HenriKorver

I've started a Demo API run and this succeeds and all calls are green:

https://vng-staging.maykin.nl/server/ed9664ef-bec9-4e08-af3c-cae60599f815/

However when checking the HTML output it shows that requests have failed:

https://vng-staging.maykin.nl/server/ed9664ef-bec9-4e08-af3c-cae60599f815/log/

This was done using the following URL: https://ref.tst.vng.cloud/demo-api/api/v2

I'm not sure which of the two is correct. Perhaps something has changed in how we call newman?

HenriKorver commented 5 years ago

I want to show the HTML output in the demo coming Thursday. So it would be nice if this could be fixed no later than tomorrow, but even better today

AlviseSembenico commented 5 years ago

Problem is addressed here https://github.com/VNG-Realisatie/api-test-platform-code/pull/59

HenriKorver commented 5 years ago

Where can I see the fix? Test server (https://vng-test.maykin.nl) gives 401 Authorization Required

AlviseSembenico commented 5 years ago

I am upgrading stage right now

AlviseSembenico commented 5 years ago

It is now updated, You have to rerun the test though

HenriKorver commented 5 years ago

I get this error:

afbeelding

AlviseSembenico commented 5 years ago

The current update should fix the problem.

HenriKorver commented 5 years ago

Where can I test the fix?

AlviseSembenico commented 5 years ago

It is now released on staging, https://vng-staging.maykin.nl/server/80dfa5d9-4309-459b-b609-a48704352bce/ here the example

HenriKorver commented 5 years ago

Super cool!!!!! Will this also be rolled out to the production server (api-test.nl)?

AlviseSembenico commented 5 years ago

Sure Henri! I will be deployed on api-test as well

HenriKorver commented 5 years ago

Today? So I can show it tomorrow on the production version

AlviseSembenico commented 5 years ago

It has been already deployed.

alextreme commented 5 years ago

Currently verifying this on production after doing the deploy.

I do get errors from the ZGW & Demo APIs, but the newman reports are being generated again and the two outputs (JSON and HTML) are more in line with each other.

HenriKorver commented 5 years ago

It worked during the live demo and thus I was very happy