search

VROOM-Project / vroom-express

Out of the box Node-express server to use VROOM as a web API.
BSD 2-Clause "Simplified" License
70 stars 60 forks source link

-c flag parameters for ETA mode #70

Closed Senseikaii closed 3 years ago

Senseikaii commented 3 years ago

Hello,

I'm trying to launch VROOM in ETA mode but can't do it using vroom-express. Do you have any recommendations on how I must launch it ?

jcoupey commented 3 years ago

You could simply add the -c flag to the command-line options passed to the system call (lookup reqOptions in file index.js). If you hard-code this, you won't be able to do regular requests any more though.

The best way to do it would be to allow overriding the -c flag on a per-request basis, exactly in the same way as with -g. A PR for this would actually be welcome.

Senseikaii commented 3 years ago

Okay, that's what I though too. Will try to work on this.

71

jcoupey commented 3 years ago

Done in #71.