Fix some minor issues in Go codes templates

VSChina / magic-modules

Magic Modules: Automagically generate Google Cloud Platform support for OSS

Apache License 2.0

1 stars 4 forks source link

Fix some minor issues in Go codes templates #13

Closed houkms closed 5 years ago

houkms commented 5 years ago

Fix some minor issues in Go codes templates.

houkms commented 5 years ago

@JunyiYi Codes are modified, find your time to check it.

JunyiYi commented 5 years ago

Thanks @houkms for the update. Please use v := item.(map[string]interface{}) instead of item := ... in the template because we will use v later in build_schema_property_get('v', output_var, prop, sdk_marshal, 8).

houkms commented 5 years ago

OK, fixed.

houkms commented 5 years ago

This PR fix the issue in this magic-module-specs PR.

houkms commented 5 years ago

@JunyiYi Other possible issues are fixed in the above commit, including

Go SDK rename: FlattenStringArray --> FlattenStringSlice and ExpandStringArray --> ExpandStringSlice
String array decision condition adjustment
Terraform configuration grammer: use block for array
Introduce help function to flatten example properties

Please find your time to review.

houkms commented 5 years ago

This PR also fixes the pipeline error in the magic-module-specs PR102

houkms commented 5 years ago

@JunyiYi Codes were refined now according to your suggestions.

houkms commented 5 years ago

Added codes to deal with the special case for tags property.