Command Line Option for GCP/Azure Switch

VSChina / magic-modules

Magic Modules: Automagically generate Google Cloud Platform support for OSS

Apache License 2.0

1 stars 4 forks source link

Command Line Option for GCP/Azure Switch #9

Closed houkms closed 5 years ago

houkms commented 5 years ago

Add command line parameter -c for GCP/Azure switch.

"GCP" for Google Cloud Platform
"MAC" for Microsoft Azure Cloud

houkms commented 5 years ago

Thanks @houkms for the contribution. Besides the comment I have provided, you also missed some places to handle Azure specific logic: core.rb, sub_template.rb, sub_template.rb.

Yes, these missing files has been modified now. And the codes are refactored according to the comments.

Besides, I found two more files, provider/config.rb, provider/config.rb, provider/ansible/documentation.rb. I added switches for all of them, although it doesn't seem to matter for provider/config.rb.

houkms commented 5 years ago

Thanks for the review. The above issues mentioned in the comments are resolved now.