VSCodium / vscodium

binary releases of VS Code without MS branding/telemetry/licensing
https://vscodium.com
MIT License
25.05k stars 1.07k forks source link

"--unity-launch" flag in Linux desktop file breaks file opening from the outside #1865

Closed xalt7x closed 4 months ago

xalt7x commented 4 months ago

Describe the bug Since v1.89.0.24126, when Linux user tries to open a file from external program (e.g., file manager), VSCodium doesn't open a file but instead it simply launches a new VSCodium window.
VSCodium's Linux desktop file still has a recently removed "--unity-launch" flag.
When I launch VSCodium with that flag, I receive such message in a terminal:

Warning: 'unity-launch' is not in the list of known options, but still passed to Electron/Chromium.

And like any other non-existing flag, it breaks opening files from the outside (e.g., codium --unity-launch launch ~/.bash_history).

Please confirm that this problem is VSCodium-specific

Please confirm that the issue/resolution isn't already documented

To Reproduce Steps to reproduce the behavior:

  1. On Linux desktop open any file manager (e.g., KDE Dolphin)
  2. Right click on any text file
  3. Choose "Open With VSCodium"
  4. New VSCodium window without requested file is launched

Expected behavior Requested file is opened in VSCodium

Desktop (please complete the following information):

Additional context The problem is reproducible with different desktops (GNOME 46, KDE Plasma 6.0) so I presume it affects all Linux users. If possible, please make a new release with the fix to avoid duplicated reports for downstream packagers (Flathub, AUR etc.)

daiyam commented 4 months ago

Not yet complete. It has to be released.

ipkpjersi commented 4 months ago

It works for me again with https://github.com/VSCodium/vscodium/releases/tag/1.89.0.24127 so I'm pretty sure this can be closed now.

resu-xuniL commented 4 months ago

It works for me again with https://github.com/VSCodium/vscodium/releases/tag/1.89.0.24127 so I'm pretty sure this can be closed now.

No , don't close please ! It doesn't work with that version neither on my machine nor other (see here : https://bbs.archlinux.org/viewtopic.php?id=295570). Had to downgrade for version 1.88.1.24104-1

daiyam commented 4 months ago

I forgot about Arch!

resu-xuniL commented 4 months ago

How dare you ?! ;) ;) ;)

ChocoTaco1 commented 4 months ago

Please fix

daiyam commented 4 months ago

vscodium and vscodium-git have been fixed. Since I'm not co-maintainer for vscodium-bin, I'm not able to do it. I've asked the maintainer but no answer.