search

Va1 / browser-sync-webpack-plugin

Easily use BrowserSync in your Webpack project.
MIT License
369 stars 40 forks source link

Improved way of injecting css + some refactoring #60

Closed malinbranduse closed 6 years ago

malinbranduse commented 6 years ago

Biggest visible change in this PR is the fact that browsersync now reloads/injects only the changed css files. Other than that, I've refactored the plugin to an ES6 class, since we've switched to that, and also the css emission file. All formatting and other changes were made by Prettier.

This PR was fragmented from my update to webpack 4 (which is coming up in the next PR), decided it's best to separate them since it might be a good addition.

Let me know what you think @Va1 .

Va1 commented 6 years ago

@malinushj looks great, thank you!

i am not happy with formatting though, i think i'll introduce automatic solution in the upcoming release

malinbranduse commented 6 years ago

Yea, sorry about that, formatting was done by Prettier, left it enabled in vscode 😅

On 17 Mar 2018, at 15:51, Valentyn notifications@github.com wrote:

@malinushj https://github.com/malinushj looks great, thank you!

i am not happy with formatting though, i think i'll introduce automatic solution in the upcoming release

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Va1/browser-sync-webpack-plugin/pull/60#issuecomment-373921675, or mute the thread https://github.com/notifications/unsubscribe-auth/AVmJf69WpdL9lebRXQnF8uu9aUMvbpy3ks5tfRTxgaJpZM4SarAq.