VadimDez / ng2-pdf-viewer

đź“„ PDF Viewer Component for Angular
https://vadimdez.github.io/ng2-pdf-viewer/
MIT License
1.31k stars 420 forks source link

Update pdfjs-dist to v4.6.82 #1139

Closed SaschaSchwarz closed 1 month ago

SaschaSchwarz commented 1 month ago
Bug Report or Feature Request (mark with an x)
- [x] Regression (a behavior that used to work and stopped working in a new release)
- [ ] Bug report -> please search issues before submitting
- [x] Feature request
- [ ] Documentation issue or request

The dependency on TS 5.6 was introduced in pdfjs-dist v4.7.76. Which led to the changes in #1138.

However, the most recent version <4.7.76 is v4.6.82.

studioromeo commented 1 month ago

Good call. I imagine it shouldn't be locked to a specific version rather track semver otherwise we will continuously miss out on fixes from pdfjs upstream. ~ would be the appropriate choice here https://github.com/npm/node-semver#tilde-ranges-123-12-1 which allows patch level changes but denies minor.

shamoon commented 1 month ago

I don’t believe they backfill releases so I don’t think there will be any minor versions < 4.7 so no point in ~ but you’re right I could’ve taken the opportunity to update to 4.6. I was more focused on un-breaking things