Vadoola / dxf2elmt

A CLI program to convert .dxf to .elmt
MIT License
0 stars 1 forks source link

Broken Text Conversion #18

Closed Vadoola closed 3 hours ago

Vadoola commented 4 hours ago

The last thing I think I need to fix with the blocks is the text in blocks didn't convert...but then I noticed I seem to have broken text conversion entirely....

In my test block with text the text just doesn't convert at all....but in another file, no blocks but lots of text the text elements appear, but all show with text "_"????. I grabbed an older copy before some of my more dramatic changes and the text conversion absolutely was working.

Vadoola commented 3 hours ago

Ah so this look like a bug from antonioaja's code that my changes bubbled to the surface. In the original code dynamic_text support was added but disabled by default. It looks like it never fully worked correctly. He incorrectly assumed the text value in dynamic text was just an text= attribute like on a normal text element but it isn't, it's a child. As part of my changes, I switched to dynamic text by default, just assuming it had worked before.

Vadoola commented 3 hours ago

This was resolved in commit 53b3b94 by correctly putting the text value in a child element under instead of as an attribute.