search

ValvePython / dota2

🐸 Python package for interacting with Dota 2 Game Coordinator
http://dota2.readthedocs.io
201 stars 32 forks source link

Replay & Metadata Url format #18

Closed Philaeux closed 6 years ago

Philaeux commented 7 years ago

Related to #9

rossengeorgiev commented 7 years ago

I don't like these at a instance methods. Maybe there needs to be a until subpackage to hold these.

Philaeux commented 7 years ago

What about a helpers.py module at the dota2/dota2/ level, next to enums.py ?

rossengeorgiev commented 7 years ago

I prefer the way its done in the steam package. There is a util subpackage that contains various helper functions.

rossengeorgiev commented 7 years ago

Hi, are you planning to finalize this PR ?

Philaeux commented 7 years ago

Sorry forgot this was on the fire. I will move them as stated in your comment https://github.com/ValvePython/dota2/pull/18#issuecomment-277550059

The part with the secret will still be open for a new PR.

rossengeorgiev commented 6 years ago

Merged in 598717e