search

ValveSoftware / Source-1-Games

Source 1 based games such as TF2 and Counter-Strike: Source
634 stars 74 forks source link

[HLS] Missing sounds using the HD pack #1345

Open Starscre4M opened 11 years ago

Starscre4M commented 11 years ago

While opting for the hd models, the pistol, magnum and m4 doesn't play their reload sounds. Also when you use the shotgun's second attack, while doing the pump movement, the sound is very out of sync, same happens with the original model but it's more noticeable using the hd.

my specs: https://gist.github.com/Starscre4M/6646322

Yesbuddy commented 11 years ago

Also, the crossbow will always shot its secondary fire instead of the explosive shot even if you use the primary fire.

Starscre4M commented 11 years ago

The explosive shot is only for multiplayer, so that's correct

chipsnapper commented 11 years ago

yeah....this pack might have more problems than i thought when i suggested it...

alfred-valve commented 11 years ago

The bug here is that the HD models are bugged wrt to the sound they issue for these events. I've not done much model work so I am unsure how to fix the models.

chipsnapper commented 11 years ago

hmm, this isn't good. this means we would need to decompile...

dscharrer commented 10 years ago

Additionally, I'm not getting any fire sounds with the refile an shotgun with the HD content enabled, only the impact sound. The pistol's fire sound is fine.

system inforation

mickeylyle commented 10 years ago

Any updates on this??

malortie commented 8 years ago

I can confirm that two weapons actually miss reload sounds. Those being glock and mp5 (9mmar).

I recompiled the model to fix these issues, at least with these two viewmodels.

As for the shotgun, I can also confirm that the pump sound is not delayed as expected, and after decompiling the model, I have not found any reference to animations events, which leads me to believe that it is handled in code. Source code handled the pump sound in the HL1 source code.

I understand that anything besides source code is not accepted as a pull request, so here is a link to the two viewmodels I fixed.

Fixed HD viewmodels

Since this is part of HD addon, you should have a folder called hl1_hd in the root folder of Half-Life 2, right after common:

common/Half-Life 2/hl1_hd

You will need to put these files in the models folder, or create it if not already existant:

.i.e:

C:/Steam/steamapps/common/Half-Life 2/hl1_hd/models/v_9mmAR.dx80.vtx C:/Steam/steamapps/common/Half-Life 2/hl1_hd/models/v_9mmAR.dx90.vtx C:/Steam/steamapps/common/Half-Life 2/hl1_hd/models/v_9mmar.mdl C:/Steam/steamapps/common/Half-Life 2/hl1_hd/models/v_9mmAR.sw.mdl C:/Steam/steamapps/common/Half-Life 2/hl1_hd/models/v_9mmar.vvd C:/Steam/steamapps/common/Half-Life 2/hl1_hd/models/v_9mmhandgun.dx80.vtx C:/Steam/steamapps/common/Half-Life 2/hl1_hd/models/v_9mmhandgun.dx90.vtx C:/Steam/steamapps/common/Half-Life 2/hl1_hd/models/v_9mmhandgun.mdl C:/Steam/steamapps/common/Half-Life 2/hl1_hd/models/v_9mmhandgun.sw.mdl C:/Steam/steamapps/common/Half-Life 2/hl1_hd/models/v_9mmhandgun.vvd

I hope this helps.

mickeylyle commented 8 years ago

@malortie it seems that the 9mm AR still doesn't have firing sounds with your fix?

malortie commented 8 years ago

@mickeylyle

I tested it this morning and it works. I also checked the paths back again as mentioned in my solution, and no errors.

I will re-upload my archive.

I suggest that you try to use the latest beta of Half-Life: Source, which is beta - Beta updates. This is the one I am currently enrolled into. In addition to this, try validating your game cache. This is just to ensure that we are on the same base.

mickeylyle commented 8 years ago

@malortie I enrolled in the beta and validated my cache, still no firing sounds. I am running Ubuntu if you think that may cause an issue?

malortie commented 8 years ago

@mickeylyle

You could add me on Steam so that we can discuss this more in depth.

mickeylyle commented 8 years ago

@malortie I can't seem to add you? i am https://steamcommunity.com/id/raevol

malortie commented 8 years ago

@mickeylyle and myself have investigated this issue and found out that the cause is due to problems mounting content from the VPK files which contain game resources such as materials, models, sounds...

The models I posted would fix the reload sound issues, however, it appears that users, including @mickeylyle, reported that firing sounds of weapons were missing.

In the _hl1hd folder, several VPKs can be found, which contain as well sounds used the HD pack. The problem is that the game actually fails to load these sounds from the archive. This appears to affect Linux users. At this time, it is unknown if Apple and other non-Windows OS users are affected.

I extracted the sound folder from this archive and asked @mickeylyle to put it in the base folder. This solved the problem.

I cannot post the sound folder, since these represent artifacts that are obtained by purchasing this game. Users will need to either wait for Valve to patch this update, or extract the sounds manually from the archive hl1_hd_pak.vpk using vpk program found in:

common/Half-Life 2/bin

and move extracted content in:

common/Half-Life 2/hl1_hd.

@mickeylyle also confirmed that being enrolled in the beta does not affect anything.

Thanks to @mickeylyle for cooperating.

mickeylyle commented 8 years ago

Thanks again @malortie !!!

Jorl17 commented 8 years ago

Still an issue (on OS X). The steps provided by @malortie work.

Jorl17 commented 8 years ago

I have made a script to automatically fix this issue on OS X and Linux. It downloads the provided viewmodels.

https://github.com/Jorl17/half-life-source-hd-sound-fix

Hope it helps other people!

sebastiennicolas commented 5 years ago

Hello there, I have the same issue, with sound in HL source. I followed instruction, and I am right now wondering what to do and where to place the script and the content of the half-life-source-hd-sound-fix-master. is this something to activate via terminal? or HL console? or drag to the common/Half-Life 2/hl1_hd folders? (Excuse my English, I am French well, sorry for that :)

tschumann commented 5 years ago

Run the script from your OS terminal, not from the Half-Life terminal - it looks like it can be executed from any directory.

Lancer le script dans l'interface système, pas dans l'interface de Half-Life - me semble que on peut le lancer de n'importe quel répertoire.

sebastiennicolas commented 5 years ago

Hello thanks for you answer! ok I made it from the terminal, and eventually it created a folder half-life-source-hd-sound-fix-master/ with inside the folders "material" and "models". After a try, sound was still missing so I deleted the "half-life-source-hd-fix-master" and kept only material and models, it worked but still missing reload sound. so imported inside the "hl1-source-hd-models-fixed-04_23_16", and everything is fine kind of. Maybe missing the 44 magnum when reloading (when old bullet out). But anyway, it much much less frustrating right now thanks! (can't believe the steam answer when you confront them to the bug, lying clowns... :)

trusktr commented 4 years ago

@Jorl17 I'm in macOS 10.14.6 and I tried running

curl https://raw.githubusercontent.com/Jorl17/half-life-source-hd-sound-fix/master/half-life-source-hd-sound-fix.sh | sh

and the output look like it completed doing what it did, however if I restart HL1 Source, or even restart Steam, I still am missing weapon sounds (namely shotgun and machine gun doesn't make firing sounds).

Does the script need an update perhaps?

Jorl17 commented 4 years ago

Hi @trusktr . If I recall correctly (it's been 4 years!), the script has additional files besides just the sh file itself and it needs those to run. I suggest cloning the repository and running the script on its own.