[TF2] MVM: tf_hud_target_id_disable_floating_health 0 bugs

[Platina6978]

In MVM, with tf_hud_target_id_disable_floating_health 0 (floating health enabled), you can see the HP of giant robots when hovering your crosshair over them. This is a very helpful and nice feature! There are some bugs with it however.

1) Regular soldier robots with any of the banners (concheror, buff banner or battalion's backup) also display their HP when aimed at. Given that these are the only small robots to do this, I assume this is an oversight/inconsistency.

2) Giants' HP won't render when looking at them through a medic's shield. May have been done to improve visual clarity, but feels worth mentioning nonetheless

3) Lastly, while I believe they are technically not giants, it may be useful to see the samurai demo's, steel gauntlet (pusher)'s and rapid fire bowman's HP, given their rather large health pools compared to other regular robots.

[jh34ghu43gu]

1) Concheror bots is a feature, as is any robot that has a self healing attribute (2nd tier bomb carriers, meds (after a quick look it seems I was mistaken about meds, at least the uber meds on w2 EE), etc...). I don't remember being able to see the other banner's health but they would be a bug I assume.

2) A shield blocks line of sight for many checks, such as engie's being able to hit their buildings. Would be nice if the check ignored shields from the same team as it would fix multiple issues ( #2850 ) including this one.

3) Opinion based suggestion; personally I don't see why we can't see all robot's health, it's not like people are doing comp callouts on med bots or the bots strategically engage in 1v1s based on expected player hp etc...

[Platina6978]

1) You were right, you can't see the HP of the other banner soldiers. Wasn't aware of this being a feature but even then it does seem inconsistent as you mentioned yourself. Also I assume it only counts for bots that passively regenerate HP? Bots like the small black box soldiers or the samurai demo's don't show their HP despite being able to regain health.

2) Wasn't aware of the other bugs, the more reason to have this looked at!

3) Mine was an opinion indeed but I felt like it'd fit here regardless! I always assumed they didn't make all bots' HP visible to prioritise visual clarity.

[jh34ghu43gu]

1) My guess is the health is only displayed if the bot has a giant tag or a regen attribute, assuming the bomb applies such an effect. Medic's self regen is a different attribute so it wouldn't count. Adding other regen attributed (on-hit/medics) might be a good idea.