ValveSoftware / csgo-osx-linux

Counter-Strike: Global Offensive
http://counter-strike.net
775 stars 69 forks source link

Skog, Metal Beartooth Aggressive Music Kit ignores mvp_volume at 0. #1767

Closed LArrowHead closed 5 years ago

LArrowHead commented 6 years ago

Your system information

Please describe your issue in as much detail as possible:

I was playing on Cobblestone on the latest update when I noticed the Skog, Metal Beartooth Aggressive Music Kit completely ignored the fact that I was on 0% MVP Volume. Previously I had been on 2% volume but it still played as if it was scaling off of something else (meaning it was louder than 2% would emit)

Steps for reproducing this issue:

  1. Launch CSGO without -scaleform option
  2. Play with Skog, Metal Beartooth Aggressive music kit or with someone that has it.
  3. Put mvp_volume at 0.
boustrophedon commented 6 years ago

This is not limited to that specific music kit, as far as I can tell it's all or most of them that ignore the MVP volume setting. Should I open a separate issue?

I think this might have happened after the fixes for sound playing at halftime when volume was at 0% because I don't remember it occurring then, but I could be wrong.

LArrowHead commented 6 years ago

@boustrophedon are you sure your mvp_volume is at 0%? I only have heard this kit in a while.

boustrophedon commented 6 years ago

2018-08-23-16 35 32 2018-08-23-16 35 30

boustrophedon commented 6 years ago

Update: I've noticed it isn't every music kit as I said before. It may only be this one in particular.

There definitely are certain ones that do play and ones that do not.

boustrophedon commented 5 years ago

@kisak-valve new update claims this is fixed. maybe add "need-retest" label?

kisak-valve commented 5 years ago

Indeed, per "– Fixed the Beartooth Music Kit to respect MVP music volume." in the 2018-09-03 CS:GO update, please retest.

boustrophedon commented 5 years ago

I don't have the kit so I'll have to wait until I notice someone getting an MVP with that kit :)

LArrowHead commented 5 years ago

@kisak-valve should be fixed

kisak-valve commented 5 years ago

Thanks, closing.