Open JoelTroch opened 9 years ago
I cannot comment on the crash atm, since I did not look enough into that yet.
Regarding the mouse issues: DMC & Ricochet client DLLs don't support the m_rawinput cvar, the input is always raw, as you can see in their inputw32.cpp. The bug with the mouse being trapped in the window rectangle has been fixed in pull request #1559 which has not been accepted so far though.
Hello.
Apparently the crash is a mistake in the code that has been fixed for Half-Life but not for DMC and Ricochet: filePos is not initialized to 0 for DMC and Ricochet, while it is for Half-Life.
Question is if you want to make a pull request fixing it or if I should? I really don't care who does, if you have fun fixing it, then go for it.
However this re-raises a serious question that I already raised in issue #1557 - Is the code for DMC and ricochet really the code they used for their Steam builds, or did they check a wrong (old) version into github????!!!!
Since you found the fix, I let you the honor to make the PR ^_^
I asked WinMerge to compare DMC 2.3 and DMC GitHub source codes, the report is there
However, the only differences I've found out so far are:
SetThink( MyMethod );
--> SetThink( &CMyClass::MyMethod );
Some C4258 warning fixes for ( int i = 0; i < something; i++ )
-->
int i; for ( i = 0, i < something; i++ )
Ok, thank you, done :-)
Deathmatch Classic and Ricochet's source codes have problems.
This is what I have done :
master
branch of this repository.projects.sln
in Visual Studio 2010.dmc
andricochet
game folders in myHalf-Life
folder.dmcmod
and my copiedricochet
asricochetmod
.game
key ofliblist.gam
ofdmcmod
&ricochetmod
, Steam now shows meDeathmatch Classic (Mod source code)
&Ricochet (Mod source code)
.dmc.dll
intodmcmod\dlls
,mp.dll
intoricochetmod\dlls
, etc...)And here are the results : DMC & Ricochet Debug : crash at "Starting local game server...", WinDBG tells me there is a memory access violation at line 1509 in
dlls/sound.cpp
(if ( pMemFile[i] == '\n' )
) DMC & Ricochet Release : working but has issue #1546 except that it also happens whenm_rawinput
is 0