search

ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.67k stars 619 forks source link

"gl_flipmatrix" should be deleted and has a crosshair bug when set to 1. #2334

Open metita opened 5 years ago

metita commented 5 years ago

There is no point on using gl_flipmatrix as it useless nowadays and make zoomed crosshair weird when set to 1.

Using zoom with AWP: imagen

imagen

10th commented 5 years ago

It also changes the sparks that glitch all over the map.

Clipboard01

metita commented 5 years ago

It also changes the sparks that glitch all over the map.

Clipboard01

You are correct.

SamVanheer commented 5 years ago

According to this website: http://www.gamerconfig.eu/command/counter-strike/gl_flipmatrix/

This cvar was added to solve problems with AMD's 3DNow! extensions, possibly when used by the 3Dfx MiniGL driver, which i don't think the engine even uses anymore.

Source does have support for 3DNow extensions, you can find the code that enables the code path here: https://github.com/ValveSoftware/source-sdk-2013/blob/0d8dceea4310fde5706b3ce1c70609d72a38efdf/mp/src/mathlib/mathlib_base.cpp#L3344-L3363

If the engine does not use these extensions then gl_flipmatrix can probably be removed.

Note that the MiniGL driver could be loaded by using an environment variable: https://github.com/spurious/SDL-mirror/blob/17af4584cb28cdb3c2feba17e7d989a806007d9f/src/video/windows/SDL_windowsopengl.c#L101-L110

But VAC will likely detect this, since it would otherwise bypass anti-cheat measures involving the replacing of opengl32.dll (which is why the launcher deletes any opengl32.dll files on startup on Windows, #1379 is a request to remove that).

I don't see why supporting MiniGL drivers is required anymore since Windows XP support has been dropped by Steam itself, so the minimum hardware requirements for the minimum supported OS probably puts MiniGL far under the minimum requirements for driver capabilities, and it probably doesn't work with the minimum required graphics cards anyway.

BUXPb commented 5 years ago

Steam still works fine on Windows XP, it’s just not updated anymore. In addition, on the official Counter-Strike and Half-Life page, the recommended system for these games is still Windows XP. Many friends still use old computers running Windows XP and do not plan to buy Windows 10 and a new computer in the near future, so that this system would work normally. Do not deprive users of the game for which they have already paid. I think for this reason Steam is still working on XP. As for gl_flipmatrix, I see no good reason to delete it. This command is used to solve problems with graphics on some old hardware. If you do not have such equipment - do not touch this setting, it will take the correct value automatically

SamVanheer commented 5 years ago

Removing this cvar won't break XP support, i'm just saying MiniGL (which nobody uses on XP anyway since SDL won't try to load it by itself) isn't worth keeping this around for.