ValveSoftware / halflife

Half-Life 1 engine based games
Other
3.67k stars 619 forks source link

[HL] Menu binds #2469

Open Mistrick opened 5 years ago

Mistrick commented 5 years ago

I don't know why but hl uses by default only keys from 1 to 5 for "slot*" cmds. Players have problems with custom server menus, they can't choose items 6-0. Add default binds for keys 6,7,8,9,0 like in CS.

Maxi605 commented 5 years ago

I never had this issue, you'll need to give more information about this.

Mistrick commented 5 years ago

Make clean install HL and look at config.cfg or default.cfg

bind    1           slot1
bind    2           slot2
binD    3           slot3
bind    4           slot4
bind    5           slot5

There are only 5 binds but menu can use all 10 slots

ghost commented 5 years ago

I agree, in Half-Life, slots 6 to 10 are unbound.

StevenKal commented 5 years ago

Not only HL is concerned by this problem (keyboard's keys 6, 7, 8, 9, 0 not binded). So the default "config.cfg" file of the related games (Half-Life, Opposing Force, and maybe others) should have those slots pre-binded, like the 1<->5 ones.

A lot of users (especially the new ones) have difficulties to handle commands (I've even seen some of them who don't know about the console and how to open it!), so let's not complicate their usage of menus commands by fixing that (both clients, normal & beta) as soon as possible! And knowing slowhacking is now fully prohibed against binds (even harmless like that), servers's owners can no longer "fix" this for their players.

afwn90cj93201nixr2e1re commented 5 years ago

by this problem

Why do you think this is a problem? By default there no situation's where we need slot 6 - slot 10 bindings in HL. 5 weapon slot's, 5 slot's in chooseteam non vgui menu style menu.

StevenKal commented 5 years ago

To afwn90cj93201nixr2e1re: Hum, it's a problem regarding 3rd-party addons (AMX...) and how many servers are using them. So, this subject is about "considerating those lasts". Besides, there is nothing wrong at changing/adding this to the default "config.cfg" file, not sure why you "complain" while this is not a request which brings inconvenients.

afwn90cj93201nixr2e1re commented 5 years ago

So, 3rd-party addons isn't official, it's must be tagged like feature request, there no bug in official hl. If you open config.cfg at hldir/valve, you can see exec userconfig.cfg, if you wanna additional bind's, you must create userconfig.cfg and add it.

afwn90cj93201nixr2e1re commented 5 years ago

But you can create issue, where you gonna ask for additional HL improvment's. Coz there more than one problem's in pure HL. Motd which doesn't support HTML lang etc. Also in cs we have bind's. cstrike/config.cfg

bind "0" "slot10"
bind "1" "slot1"
bind "2" "slot2"
bind "3" "slot3"
bind "4" "slot4"
bind "5" "slot5"
bind "6" "slot6"
bind "7" "slot7"
bind "8" "slot8"
bind "9" "slot9"

valve/config.cfg (used by HL)

bind "1" "slot1"
bind "2" "slot2"
bind "3" "slot3"
bind "4" "slot4"
bind "5" "slot5"

@kisak-valve add Half-life, feature-request, @mikela-valve check it too.

StevenKal commented 5 years ago

Note that not only HL seems to be concerned, I've tested on Opposing Force (with a client build #7561) and I have slot 8 & 9 unbinded on a default "config.cfg". I've not checked the others (DMC, Ricochet), so @mikela-valve, feel free to control them internally.

ghost commented 1 year ago

Replying to https://github.com/ValveSoftware/halflife/issues/2469#issuecomment-495996672

Thank you so much! I was having the same issue as OP's and now it's solved. 😊

SamVanheer commented 10 months ago

This is still a problem and should be addressed by changing the default key bindings.

In gfx/shell/kb_def.lst (default bindings):

"1"             "slot1"
"2"             "slot2"
"3"             "slot3"
"4"             "slot4"
"5"             "slot5"
"6"             "slot6"
"7"             "slot7"
"8"             "slot8"
"9"             "slot9"
"0"             "slot10"

in gfx/shell/kb_act.lst (keyboard options page):

"slot1"         "#Valve_Weapon_Category_1"
"slot2"         "#Valve_Weapon_Category_2"
"slot3"         "#Valve_Weapon_Category_3"
"slot4"         "#Valve_Weapon_Category_4"
"slot5"         "#Valve_Weapon_Category_5"
"slot6"         "#Valve_Weapon_Category_6"
"slot7"         "#Valve_Weapon_Category_7"
"slot8"         "#Valve_Weapon_Category_8"
"slot9"         "#Valve_Weapon_Category_9"
"slot10"        "#Valve_Weapon_Category_0"

In resource/valve_english.txt (localizations):

"Valve_Weapon_Category_1"       "Weapon category 1"
"Valve_Weapon_Category_2"       "Weapon category 2"
"Valve_Weapon_Category_3"       "Weapon category 3"
"Valve_Weapon_Category_4"       "Weapon category 4"
"Valve_Weapon_Category_5"       "Weapon category 5"
"Valve_Weapon_Category_6"       "Weapon category 6"
"Valve_Weapon_Category_7"       "Weapon category 7"
"Valve_Weapon_Category_8"       "Weapon category 8"
"Valve_Weapon_Category_9"       "Weapon category 9"
"Valve_Weapon_Category_0"       "Weapon category 10"

Changing the default key bindings does not add the bindings to existing config files. Users will still have to bind them manually.