search

VazkiiMods / Patchouli

Accessible, Data-Driven, Dependency-Free Documentation for Minecraft Modders and Pack Makers
https://vazkiimods.github.io/Patchouli/
Other
316 stars 124 forks source link

[Feature Request] Advancement trigger for building multiblocks #121

Open thephoenixlodge opened 5 years ago

thephoenixlodge commented 5 years ago

As per the title, it would be great if there could be an advancement trigger (especially if compatible with triumph - could take a look at how BotaniaTweaks does this perhaps?) that would trigger on completion of building a multiblock from a visualization. I think this would be very useful for both pack devs and modders - Nature's Aura for example currently checks for construction of it's Natural Altar by checking if the player has an item that can only be crafted using it.

This would need a way to identify which multiblock is being checked for, but this could probably just piggyback off the already existing multiblock_id used by modders.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open for a while with no activity. Please bump if this is still an issue, or this ticket will be closed soon.

tabr commented 3 years ago

This function is need.

TheRealWormbo commented 11 months ago

I'm seeing a bit of an issue with this suggestion. Looking at it from a Botania perspective, the multiblocks from the book are not actually what the Botania structures end up checking against. (The Alfheim portal has sample pylons and mana pools, even though their position is very free-form; the enchanter has sample flowers, but doesn't enforce that specific type; and the gaia arena comes with a 3x3 beacon base made of iron blocks, which is not actually part of the arena structure check.) Also, I believe the multiblock visualizer is completely client-side. If a mod wants to trigger an advancement for building a structure, its server-side logic that verifies the actual multiblock being used can easily trigger an advancement when a player completes or successfully activates the structure for the first time. That also makes a lot more sense if a player manages to build the structure from memory instead of using the visualizer.