VazkiiMods / Patchouli

Accessible, Data-Driven, Dependency-Free Documentation for Minecraft Modders and Pack Makers
https://vazkiimods.github.io/Patchouli/
Other
314 stars 124 forks source link

Multiblock visualization does not render non-vanilla block entities #751

Open TheRealWormbo opened 5 months ago

TheRealWormbo commented 5 months ago

Mod loader

Fabric, Forge, likely also NeoForge

Minecraft version

1.20.1 (also likely 1.20.6+)

Patchouli version

1.20.1-84 (both Fabric and Forge)

Modloader version

Forge 47.2.0, Fabric Loader 0.15.6, Fabric API 0.92.1+1.20.1

Modpack info

No response

The latest.log file

(n/a)

Issue description

The MultiblockVisualizationHandler#renderMultiblock uses BlockRenderDispatcher#renderSingleBlock, a vanilla method which can only render blocks that either use RenderShape#MODEL or are a one of a selected number of vanilla block items if using RenderShape#ENTITYBLOCK_ANIMATED.

(For rendering on a page, a different rendering approach is implemented, which can handle custom block entities properly.)

Steps to reproduce

No response

Other information

An example of this issue is VazkiiMods/Botania#4181, where floating flowers in the Mana Enchanter multiblock are displayed on the book page, but not in the in-world visualization, unless Botania's client configuration rendering.staticFloaters is enabled, which renders floating flowers as block models, but prevents them from being animated.

As far as I can tell, this behavior of BlockRenderDispatcher#renderSingleBlock has not changed in 1.20.6 either, and I wouldn't be surprised if it still exists in 1.21, so this issue is probably going to stay relevant for newer versions as well.