search

Versent / redux-crud

A set of standard actions and reducers for Redux CRUD Applications
MIT License
624 stars 54 forks source link

Bugfix: merge record contents with existing record keyed by cid on createSuccess #48

Closed jsherbert closed 7 years ago

jsherbert commented 7 years ago

Using the new Map reducer, creating a record with a cid via createStart and running createSuccess with the new record data and the cid results in a record empty save for a _cid property.

This looks like a typo and a missed test (merging into the record's key rather than the record), so I added a test to confirm and fixed. Let me know if I've missed something here.

Thanks for the Map reducers, I'd forked your repository and added the same functionality with a view to a PR but the new Typescript implementation is much nicer.

sporto commented 7 years ago

Thanks for the fix.

sporto commented 7 years ago

Published 3.0.4