search

Versent / saml2aws

CLI tool which enables you to login and retrieve AWS temporary credentials using a SAML IDP
https://github.com/Versent/saml2aws
MIT License
2.09k stars 563 forks source link

Customizable KeyCloak password error validator #1275

Closed kenjikikuchi closed 6 months ago

kenjikikuchi commented 6 months ago

This PR is for the issue https://github.com/Versent/saml2aws/issues/1265. Thank you.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 42.08%. Comparing base (16a69e6) to head (5faf7c8). Report is 16 commits behind head on master.

Files Patch % Lines
pkg/provider/keycloak/keycloak.go 63.63% 7 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1275 +/- ## ========================================== + Coverage 41.93% 42.08% +0.15% ========================================== Files 54 54 Lines 6386 6427 +41 ========================================== + Hits 2678 2705 +27 - Misses 3271 3280 +9 - Partials 437 442 +5 ``` | [Flag](https://app.codecov.io/gh/Versent/saml2aws/pull/1275/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Versent/saml2aws/pull/1275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | `42.08% <63.63%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kenjikikuchi commented 6 months ago

@mapkon, thank you for merging this PR. I am looking forward to seeing the next release!

And again, thank you for developing and maintaining this awesome software! 👍

mapkon commented 5 months ago

@mapkon, thank you for merging this PR. I am looking forward to seeing the next release!

And again, thank you for developing and maintaining this awesome software! 👍

Should be released now. It should take a bit to percolate through the binary/package distribution systems.

mapkon commented 5 months ago

@mapkon, thank you for merging this PR. I am looking forward to seeing the next release!

And again, thank you for developing and maintaining this awesome software! 👍

Thanks @kenjikikuchi for the kind words, but I am not the developer - that is @wolfeidau. I am just a simple maintainer.