VeryGoodOpenSource / very_good_cli

A Very Good Command-Line Interface for Dart created by Very Good Ventures 🦄
http://cli.vgv.dev
MIT License
2.15k stars 188 forks source link

fix: `very_good create flutter_app` doesn't create `.gradlew` file. #762

Closed yahu1031 closed 1 year ago

yahu1031 commented 1 year ago

Description When creating a new flutter app with vgv cli, it is not generating .gradlew file in android folder.

Steps To Reproduce

  1. Install vgv cli (already done)
  2. create a new project using this command - very_good create flutter_app <SOME_NAME> --application-id <SOME.ID>
  3. Try integrating shorebird.
  4. Got this error
mr.minnu@minnu <SOME_NAME> % shorebird init
✗ Detecting product flavors (3ms)
Unable to extract product flavors.
Could not find android/gradlew.
Make sure you have run "flutter build apk at least once.

Expected Behavior Everything should work smoothly.

Additional Context

This is happening in the mac.

ProductName:        macOS
ProductVersion:     14.0
BuildVersion:       23A5286i
Flutter 3.10.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision f468f3366c (8 days ago) • 2023-07-12 15:19:05 -0700
Engine • revision cdbeda788a
Tools • Dart 3.0.6 • DevTools 2.23.1
$very_good --version
0.15.0
jazz-mobility commented 1 year ago

flutter create test_app generates the gradlew file.

jazz-mobility commented 1 year ago

setting ANDROID_HOME fixed the issue with VGV app

export ANDROID_HOME="$HOME/Library/Android/sdk"
yahu1031 commented 1 year ago

But ideally that should not be the case.