ViennaRSS / vienna-rss

Vienna is a free and open-source RSS/Atom newsreader for macOS.
https://www.vienna-rss.com
Apache License 2.0
1.85k stars 227 forks source link

Empty Wallabag Feed shows a ⚠️ #1790

Closed chevdor closed 2 months ago

chevdor commented 3 months ago

Describe the bug Using a valid subscription on a Wallabag feed that has no content shows a ⚠️

To Reproduce

Screenshots

image

Please complete the following information:

I mentioned Wallabag since I see the issue there but it may or not be related to Wallabag.

Response of an empty feed image ``` wallabag — unread feed Atom feed for unread entries wallabag:wallabag.redacted.org:will:unread wallabag will https://wallabag.redacted.org/favicon.ico https://wallabag.redacted.org/bundles/wallabagcore/themes/_global/img/logo-square.png ```
Response of a non empty feed image ``` wallabag — unread feed Atom feed for unread entries wallabag:wallabag.redacted.org:will:unread 2024-08-10T12:03:59+00:00 wallabag will https://wallabag.redacted.org/favicon.ico https://wallabag.redacted.org/bundles/wallabagcore/themes/_global/img/logo-square.png <![CDATA[GitHub - ViennaRSS/vienna-rss: Vienna is a free and open-source RSS/Atom newsreader for macOS.]]> wallabag:wallabag.redacted.org:will:entry:329 2024-08-10T12:03:59+00:00 2024-08-10T12:03:59+00:00 ViennaRSS ```
barijaona commented 3 months ago

This is deliberate. Details of feeds are logged in Activity window: that includes reasons for marking them with a ⚠️

chevdor commented 3 months ago

In the activity window, I see:

image

Why would a feed with no content raise a warning ?

barijaona commented 3 months ago

As far as I remember, the intent was to warn of a stale feed. I might change this: keep the log message but suppress the ⚠️

Opinions @ViennaRSS/maintainers ?

Eitot commented 3 months ago

I am in favour of removing the error icon in this case.

chevdor commented 3 months ago

This is my first issue, I take the chance to thank you and congratulate for the very nice piece of software 🙏

I think the log is totally fine as it may in some case be an important info to help spot issues. Some feeds however may be empty and that's totally fine.

As a (new) user, I saw the warning and concluded that something was wrong with my config (url, auth, etc...) whereas there was nothing wrong at all.

In this case, an option could be to show an ℹ️ icon instead but I would not even do that. The info is "the feed is empty" which is obvious when looking at the empty list.

An option could be also to specifically show a 0 on the feed counts but that is likely not very aesthetic and again not really useful.

The ⚠️ makes sense if the request fails (404, 5xx, etc...) but IMO is more confusing than helpful on empty feeds.

So removing the warning for empty feeds if the request was successful is IMO the best way to go.

barijaona commented 2 months ago

Closed by Version 3.9.2