Vimjas / vint

Fast and Highly Extensible Vim script Language Lint implemented in Python.
MIT License
703 stars 33 forks source link

Update vim-vimparser (support BLOB, CONST, EVAL, HEREDOC, METHOD) #358

Closed tyru closed 4 years ago

tyru commented 4 years ago

Fix #357 Fix #337


Update to vim-jp/vim-vimlparser@90895c3 . And just I have added node types for new nodes.


But this PR doesn't solve map()'s arity errors. This should be fixed by separated PR, I think.

スクリーンショット 2020-03-06 23 40 21
tyru commented 4 years ago

ah, BLOB and CONST are included to the previous vimlparser.py, but node types are not supported?

tyru commented 4 years ago

map()'s arity errors.

was caused by https://github.com/Vimjas/vint/blob/fb6fa167a488d6e5b63d3516ca9c24eba0fc35b7/vint/linting/policy/prohibit_invalid_map_call.py

The policy should care NODE_METHOD.

tyru commented 4 years ago

Zapped all issues, and added issue numbers to top comment.

tyru commented 4 years ago

@blueyed Can I merge this?

tyru commented 4 years ago

It looks like I cannot merge this :o Maybe collaborator cannot merge to master?

スクリーンショット 2020-03-19 19 46 38

blueyed commented 4 years ago

@tyru updated your perms - it was "Triage" before only, now it is "Write".

tyru commented 4 years ago

@blueyed Thanks!

Shane-XB-Qian commented 3 years ago

hello~ did this included https://github.com/vim-jp/vim-vimlparser/pull/159 ? looks that fixed earlier than those, but 'default argument =' looks still not supported.. i install vint by pip, or was there a way to upd vimlparser manually?

Shane-XB-Qian commented 3 years ago

i just tried to verify the effective result.. so far looks a bit not-upd-2-date.. and a bit slow (with syntastic) if viml more than thousand lines.. fyi...........