Vincent-P / gruvbox-intellij-theme

An IDE theme based on the gruvbox color scheme. ⛺
https://plugins.jetbrains.com/plugin/12310-gruvbox-theme
MIT License
126 stars 65 forks source link

Use a more distinguishable colour for errors #48

Closed velitasali closed 3 years ago

velitasali commented 3 years ago

Hello,

First of all, thank you for this awesome theme. I am using it on all the JetBrains IDEs and I want to make a suggestion.

Kotlin, Unmodified Dark Medium Theme & Colour Scheme Screenshot from 2021-02-21 20-10-01

I am aware that the deprecation is styled with italic text and keywords aren't underlined in normal circumstances, however, because, most of the time what helps me distinguish errors is the colour, I think it would be great if the error colour was different so it could be more distinguishable. Or the red colour reserved for errors only.

Thanks, Keep up the good work :)

Vincent-P commented 3 years ago

It is an interesting problem and I am not sure how it is handled in other IDEs. If anyone has suggestions on how it should look feel free to try and post here.

Keywords are red in the original gruvbox vim theme so maybe errors need another color?

velitasali commented 3 years ago

Not sure what would be the right choice, however, I think a different colour could be enough.

In this instance, I used #B8BB26 which is part of the colour scheme:

Screenshot from 2021-05-13 15-03-53

Vincent-P commented 3 years ago

So with #49, function and method calls have no special foreground anymore. I also changed errors and deprecation warnings to only have a red underwave so now the red foreground is exclusively for keywords.