Vinelab / minion

A Simplified Client for WAMP v2 (Web Application Messaging Protocol) with command line support - PHP WebSocket Made Easy
MIT License
126 stars 16 forks source link

Could you allow to pass in the React Loop #12

Closed andho closed 6 years ago

andho commented 7 years ago

I have an existing app that's running on React. I'm replacing the WebSocket server with Minion, but I need to keep other things that depends on it.

As a library, please allow the user to pass in an instance of the Loop as mentioned in the documentation: https://github.com/reactphp/event-loop.

Mulkave commented 7 years ago

@andho Thanks for the suggestion, how do you see that happen? In a service provider somewhere or to a specific class?

NeoVance commented 6 years ago

@Mulkave @andho Fixed by #20

Mulkave commented 6 years ago

Great, thanks @NeoVance.