search

Vinelab / minion

A Simplified Client for WAMP v2 (Web Application Messaging Protocol) with command line support - PHP WebSocket Made Easy
MIT License
126 stars 16 forks source link

phpunit does not seem to be working correctly anymore in php 7+ #21

Closed NeoVance closed 6 years ago

NeoVance commented 6 years ago

This commit provides updated thruway/client as well as phpunit

Mulkave commented 6 years ago

Thanks for the PR! This requires and update in travis.yml file as well in order to run the tests under php 7+ instead of 5+

Mulkave commented 6 years ago

Once this is done, will release a new version having all three changes together. Cheers!

NeoVance commented 6 years ago

Trying to figure out a way to split the tests, so that we can continue to test against at least 5.6 and 7.0+

Unfortunately every version of PHPUnit that supports 7.0+ requires 7.0+ dropping support for 5.x versions of PHP. Anyone have any thoughts on how to get around this? Most of my work with PHPUnit so far has targeted a single version of PHP, but I can see with Minion you might want to have some backwards compatibility.

NeoVance commented 6 years ago

This is going to break testing on PHP versions pre 7.0.

It might be possible to support it by aliasing the class name, and having users install their own global phpunit rather than requiring a specific version.