Vinifera-Developers / Vinifera

Vinifera is a C&C: Tiberian Sun engine extension implementing new logics and fixing bugs.
GNU General Public License v3.0
45 stars 10 forks source link

[Vanilla Bug] DamageParticleSystems doesn't work properly on InfantryTypes #98

Open Crimsonum opened 3 years ago

Crimsonum commented 3 years ago

Description:

Much like vehicles, cyborgs can emit sparks when damaged. However, in the vanilla game this doesn't work due to a bug in DamageParticleSystems: it must be redefined in the map file for it to work on InfantryTypes.

Conditions:

[CYBORG]
DamageParticleSystems=SparkSys

Steps To Reproduce:

  1. Play on any map as Nod and train a Cyborg.
  2. Reduce the Cyborg's health below 50%. No sparks will be emitted.
  3. Close the game. Insert the above bit of code to the map file and replay it.
  4. Train a Cyborg and reduce its health below 50%. Sparks will be correctly emitted.
Crimsonum commented 3 years ago

In addition to fixing this bug, it would be beneficial for modders to allow InfantryTypes to use both spark and smoke-type ParticleSystems as DamageParticleSystems, as well as regardless of Cyborg status.

CCHyper commented 3 years ago

@Crimsonum:

In addition to fixing this bug, it would be beneficial for modders to allow InfantryTypes to use both spark and smoke-type ParticleSystems as DamageParticleSystems, as well as regardless of Cyborg status.

Perhaps it would be best for you to open a new feature request for this so it can be referenced cleanly.

Crimsonum commented 3 years ago

Perhaps it would be best for you to open a new feature request for this so it can be referenced cleanly.

Done.