search

Visanduma / nova-two-factor

Laravel nova in-dashboard 2FA feature
56 stars 31 forks source link

Adding whitespace on dist translation key #41

Closed devnicolas1 closed 1 year ago

devnicolas1 commented 1 year ago

This pull request complements the #40. The main problem is the fact that the translation key was missing a whitespace, which made all the translations to stop working. Although the PR #40 fixed the problem in the code itself, the dist.js file, which is the one actually used by Nova, still had the same issue, which made the problem to persist.

This PR does not recompile the JS code. It literally only adds a whitespace in the translation key, and nothing more.

devnicolas1 commented 1 year ago

@lahirulhr I suppose this should be the final fix for the translation key issue. Sorry for the inconvenience.

lahirulhr commented 1 year ago

it's my bad too. now i, rebuilt the assets with new translation key.