search

Vitaliy-1 / JATSParser

JATSParser is aimed to be integrated with Open Journal Systems 3.0+ for transforming JATS XML to various formats
GNU General Public License v3.0
11 stars 21 forks source link

Fatal error if submission file deleted #25

Closed NateWr closed 4 years ago

NateWr commented 4 years ago

If a submission file has been selected under Publication > Full Text, and that file is then deleted, this plugin will throw a fatal error on line 991 (https://github.com/Vitaliy-1/JATSParserPlugin/blob/master/JatsParserPlugin.inc.php#L991) because a $submissionFile is empty. I'd suggest checking for a valid return here (https://github.com/Vitaliy-1/JATSParserPlugin/blob/master/JatsParserPlugin.inc.php#L983) before adding to the $submissionFiles array.

NateWr commented 4 years ago

Woops, should have been on the other repo. Posted the issue there: https://github.com/Vitaliy-1/JATSParserPlugin/issues/36