VolkovLabs / business-forms

The Business Forms panel is a conceptually new plugin for Grafana. It is the first plugin that allows inserting and updating application data, as well as modifying configuration directly from your Grafana dashboard.
https://docs.volkovlabs.io
Apache License 2.0
86 stars 10 forks source link

When defining show if true, dashboard crashes #408

Closed craftzneko closed 5 months ago

craftzneko commented 6 months ago

I have a a lot of elements and i find that the dashbaord tries to evalute the section "show if true" before i have even finished typing causing a JS crash. This means i often end up having to type the code outside of the window first and then pasting in. Is there a way it could not evaluate the code or at least not cause a crash and lose the entire changes made?

Also i am not sure how to recover my dashbaord now, everytime it loads it goes into a crash loop, also not sure if this is a grafana error but after a crash, any defined variables on the dashboard are lost and i have to recreate them again

vitPinchuk commented 6 months ago

Hi @craftzneko Could you please share more details (video) “Show if true” should apply code to onBlur changes + timeout

craftzneko commented 6 months ago

Here is a video showing the issue. The problem is that when you click off that section it auto saves. There are many reasons why you might want to move away from there before the code is typed for example i might need to take a teams call on my device so i click answer and as it loses focus it attempts a save and then leaves the dashboard in an unrecoverable state, needed to restore back to a previous version or lose all the code you may have typed in that session. Additionally this may be a grafana issue but all dashbaord variables are then also lost

https://github.com/VolkovLabs/volkovlabs-form-panel/assets/662108/88d49a0e-0f74-4e63-8367-361c1428330a