The Business Forms panel is a conceptually new plugin for Grafana. It is the first plugin that allows inserting and updating application data, as well as modifying configuration directly from your Grafana dashboard.
Thank you for your update submission. I've reviewed the code and changes, which appear to be in order. However, I have some questions and observations regarding this update, particularly considering the breaking changes it introduces.
Migration Script
We tested the new plugin version with your own older provisioned files and noticed that the migration script doesn't cover all cases. Could you take another look to ensure a smoother migration process for users?
The test I did was simple, run the old version with old provisioned files, see how panels work, then update the plugin using the same provisioned files and observe some panels breaking.
Given that this is a major release, breaking changes are understandable I am just letting you know in case you want to take a second look but if you want to publish the update as is we can go ahead.
Provisioned Files
When testing the newer version with the new provisioned files, I encountered several errors across different panels. These seem to be configuration-related rather than plugin malfunctions. Please review your provisioned files, paying attention to:
Outdated options (e.g., "options" instead of "context.panel.options")
Most of the errors come from forms failing to send. This is not caused by the local test servers not running or the data sources not being configured.
Test Server
The provided test server (https://volkovlabs-feedback.deno.dev/) for the feedback Deno form returns a 404 when a POST request go to it. This occurs both with the online server and when running it locally with deno.
Panel Issues
"Configuration" panels throw an error when updating values: "An error occurred updating values."
The e2e test panel works fine.
The files panel doesn't work with base64 upload.
Several other panels don't seem to function properly with the provisioned files.
Please feel free to respond if you'd like to submit the update as is or if you need any clarification on these points.
Hi Mikhail,
Thank you for your update submission. I've reviewed the code and changes, which appear to be in order. However, I have some questions and observations regarding this update, particularly considering the breaking changes it introduces.
Migration Script
We tested the new plugin version with your own older provisioned files and noticed that the migration script doesn't cover all cases. Could you take another look to ensure a smoother migration process for users?
The test I did was simple, run the old version with old provisioned files, see how panels work, then update the plugin using the same provisioned files and observe some panels breaking.
Given that this is a major release, breaking changes are understandable I am just letting you know in case you want to take a second look but if you want to publish the update as is we can go ahead.
Provisioned Files
When testing the newer version with the new provisioned files, I encountered several errors across different panels. These seem to be configuration-related rather than plugin malfunctions. Please review your provisioned files, paying attention to: Outdated options (e.g., "options" instead of "context.panel.options") Most of the errors come from forms failing to send. This is not caused by the local test servers not running or the data sources not being configured.
Test Server
The provided test server (https://volkovlabs-feedback.deno.dev/) for the feedback Deno form returns a 404 when a POST request go to it. This occurs both with the online server and when running it locally with deno.
Panel Issues
"Configuration" panels throw an error when updating values: "An error occurred updating values." The e2e test panel works fine. The files panel doesn't work with base64 upload. Several other panels don't seem to function properly with the provisioned files.
Please feel free to respond if you'd like to submit the update as is or if you need any clarification on these points.
-- Esteban