VolkovLabs / business-text

The Business Text panel plugin allows you to construct a text visualization template from the values of a dataset returned by a data source query.
https://docs.volkovlabs.io
Apache License 2.0
81 stars 13 forks source link

Open link in new tab #266

Closed krugster closed 8 months ago

krugster commented 9 months ago

Is it possible to have a link within the Dynamic Text panel open in a new tab?

I've tried using the same approach as recommended for Grafana value links: ID: <a href="https://test.com/{{{@root.id}}}" target="_blank">{{{@root.id}}}</a>

But it still tries to open in the same tab/window.

mikhail-vl commented 8 months ago

@krugster It's probably related to the Sanitized mode enabled, I just tested it without and it works as expected.

Please take a look at the documentation: https://volkovlabs.io/plugins/volkovlabs-dynamictext-panel/content/#html-sanitization

krugster commented 8 months ago

Thanks Mikhail. It looks like these environment variables aren't supported in Grafana cloud which is what I'm using...am I correct?

On Sun, 25 Feb 2024 at 21:58, Mikhail Volkov @.***> wrote:

@krugster https://github.com/krugster It's probably related to the Sanitized mode enabled, I just tested it without and it works as expected.

Please take a look at the documentation: https://volkovlabs.io/plugins/volkovlabs-dynamictext-panel/content/#html-sanitization

— Reply to this email directly, view it on GitHub https://github.com/VolkovLabs/volkovlabs-dynamictext-panel/issues/266#issuecomment-1963320399, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJCYVNRKCY3CSOZGFNE53YVQJA3AVCNFSM6AAAAABC5Q267CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTGMZDAMZZHE . You are receiving this because you were mentioned.Message ID: @.***>

mikhail-vl commented 8 months ago

@krugster You need to create a support ticket to disable sanitized mode in Grafana Cloud.

In future releases, maybe Grafana 11, you should be able to update settings from the UI.

krugster commented 8 months ago

Ahh great. Thanks for that.

krugster commented 8 months ago

Apologies for coming back around to this, but Grafana support has told me they are not able to disable this because it opens the environment up to XSS vulnerabilities as seen here - https://www.okta.com/identity-101/xss-vulnerability/

Any other suggestions for opening links in a new tab?

On Tue, 27 Feb 2024 at 21:36, Perry Krug @.***> wrote:

Ahh great. Thanks for that.

mikhail-vl commented 8 months ago

@krugster It's something new, the settings was updated to other customers as I heard.

@asimonok any other suggestions?