search

VoltzEngine-Project / Engine

Minecraft modding core lib
Other
13 stars 11 forks source link

[1.7.10] Minecraft Crash (Rendering item) #45

Closed ghost closed 8 years ago

ghost commented 8 years ago

Minecraft Version: -1.7.10 Forge Version: -image

VoltzEngine Version: -image

is this the latest curseforge build?

Please Pastebin crash

Crash Report: ----------crash-2016-08-13_23.52.27-client.txt

Explain issue in detail: When I When I search "v" or "eng" in the transmutation table that is in ProjectE , it just crash my game https://github.com/sinkillerj/ProjectE/issues/1329

DarkGuardsman commented 8 years ago

I blame project E but I can add checks to fix it on my end.

MaPePeR commented 8 years ago

Yea, its partly ProjectEs fault, but there is not really a lot we could do about this except ASM-ing a try/catch into the Item-Render-Pipeline... and that is not something i would like to do and it would not be a real fix anyway...

DarkGuardsman commented 8 years ago

Well validating or spawning the item with its original NBT would fix the problem. As the tools use NBT to figure out what type they are as the metadata is used for damage. I'm seeing this same problem pop up in my other mods. Where Project E is messing with the NBT in some odd way, maybe not directly but it is causing broken items to be spawned.

MaPePeR commented 8 years ago

Thats the problem: there is no way to "validate" the NBT... You never really know, which items need to keep their NBT and which not.

DarkGuardsman commented 8 years ago

Ya, but then the safe way is to never remove NBT from an item. Then lets mods implement an API to remove their own NBT data as needed. Other wise even if I implement NPE checks on my end the item is broken anyways key point https://github.com/BuiltBrokenModding/ICBM/issues/225. Where the items validation code caught the error but now the item is broken.

DarkGuardsman commented 8 years ago

Issue should be fixed https://github.com/BuiltBrokenModding/VoltzEngine/commit/8f744cef681fc324d738c9b25b8f8bb0ba80c02f

Implemented registering the tools with Project E's whitelist. Have yet to fully test it as I don't know how to use Project E. Will learn the mod later and test that the fix fully works. However, for now I will close the issue.