search

VoltzEngine-Project / Engine

Minecraft modding core lib
Other
13 stars 11 forks source link

VE and Enderio Compat issue #56

Closed dmodoomsirius closed 7 years ago

dmodoomsirius commented 7 years ago

Minecraft Version: 1.7.10

Forge Version: 10.13.4.1614

VoltzEngine Version: 0.23.1.11

Enderio Version: 1.7.10-2.3.0.429_beta

is this the latest curseforge build? Yes Please Pastebin crash

Crash Report: https://gist.github.com/dmodoomsirius/6bff79efeaa8c8b0c2e7c219b3bbdc07

Explain issue in detail:

Crash on load. Does not happen without VoltzEngine

dmodoomsirius commented 7 years ago

I can reproduce with just VE, EnderCore and EnderIO, https://gist.github.com/dmodoomsirius/3de9d2de38ad5913f4feefaa8ca82cdf

zmaster587 commented 7 years ago

I'm getting reports of a similar issue with libvulpes and VE. Also similar thing occuring with VE + buildcraft-7.1.18 ( http://pastebin.com/6bcx13PZ ). Buildcraft launches fine without VE.

DarkGuardsman commented 7 years ago

Ya I'm not sure what is causing this but it is triggering on everything containing COFH energy code. It could be the ASM injector but that shouldn't mess with anything outside of the com.builtbroken package. We also do not ship the API for COFH either so this is very odd.

zmaster587 commented 7 years ago

I strongly suspect ASM injection of some kind because in the dev env I do not allow any ASM injection by anything other than AR/libVulpes and it loads just fine. Although there may be other things at play in the dev env. I'll try enabling ASM from VE in dev env and see if it crashes

DarkGuardsman commented 7 years ago

If it is the asm luckily it comes with an off switch in the runtime so could be disabled. As well I'm adding a ton of debug to the ASM to see if it crashes during the transform call. Problem is the ASM should only run on "com.builtbroken" packages and should never mess with other mods.

DarkGuardsman commented 7 years ago

https://github.com/BuiltBrokenModding/VoltzEngine/blob/development/src/main/scala/com/builtbroken/mc/core/asm/template/ClassTransformer.java

zmaster587 commented 7 years ago

err, the configs appear to be empty when generated in the wild... except wooden buckets

DarkGuardsman commented 7 years ago

Its a system arg to disable the ASM since I would have to write my own config generator to use it as ASM time.

zmaster587 commented 7 years ago

ahh, makes sense

DarkGuardsman commented 7 years ago

-DenableAsmTemplates=false

DarkGuardsman commented 7 years ago

hmm just ran VE and EnderIO locally in MultiMC I can confirm it is broken. As well that it can't find anything in the COFH api folder. Something is preventing it from loading but I am unsure what?

13:37:42] [main/INFO]: TemplateManager: loading ASM templates... [13:37:42] [main/ERROR]: TemplateManager: Skipping RF support - class not found [13:37:42] [main/ERROR]: TemplateManager: Skipping IC2 support - class not found [13:37:42] [main/INFO]: TemplateManager: Finished loading...

[13:37:54] [Client thread/INFO]: [Voltz-Engine] Found method func_150807_a [13:37:54] [Client thread/INFO]: Injected instruction to method: func_150807_a [13:37:55] [Client thread/ERROR]: Not loading RF support as we couldn't detect cofh.api.energy.IEnergyHandler class or interface.

DarkGuardsman commented 7 years ago

So I can confirm it is not the ASM as it is not touching any of the failed classes. My next theory is that something is breaking how classes are loading. I'm going to check every place I look for COFH api and tweak it a little bit.