Ores missing an unlocalized name

VoltzEngine-Project / Engine

Minecraft modding core lib

Other

13 stars 11 forks source link

Ores missing an unlocalized name #76

Closed LemADEC closed 7 years ago

LemADEC commented 7 years ago

Minecraft Version: -1.7.10 Forge Version:

Forge10.13.4.1614 VoltzEngine Version:
1.7.10-1.4.0b95

Explain issue in detail: In SMP, ores are missing an unlocalized name (returning null), this causes issues with UndergroundBiomesConstruct which uses that name to create their owns.

DarkGuardsman commented 7 years ago

localized names are client side and that is a poor design on that mods part. Either way I'll look into it but the mod should use registry names.

LemADEC commented 7 years ago

UBC definitly could use some thought on its design and implementation, that I completely agree. I'm confused on why getUnlocalizedName() would be client side only and be allowed to report null. On 1.10, it's still accessible and not supposed to report null.

DarkGuardsman commented 7 years ago

Localizations are only loaded client side so it would be assumed it has nothing to do with server logic. That being said its most likely an easy fix but I have yet to look at it.

LemADEC commented 7 years ago

Fix is working properly