search

Voxelum / x-minecraft-launcher

An Open Source Minecraft Launcher with Modern UX. Provide a Disk Efficient way to manage all your Mods!
https://xmcl.app/
MIT License
714 stars 105 forks source link

launcher process doesn't exit #838

Open paring-chan opened 2 days ago

paring-chan commented 2 days ago

Is there an existing issue for this?

Launcher Version

v0.47.10

Operating System

Linux

Architecture

x64

Current Behavior

while running some tasks on the launcher(installing, launching, etc), it occasionally freezes and doesn't respond if I hit cancel button. Then the process won't be killed even with SIGKILL

Expected Behavior

No response

Steps To Reproduce

  1. Do any task like launching, installing, updating instance and check if it freezes
  2. Then stop xmcl
  3. Check task manager: it still remains and killing the process does not work

Anything else?

I'm using KDE Plasma 6.2.2 on Wayland and system is running with NixOS

ci010 commented 1 day ago

I observe this sometime in my dev env. I guess this might be related to database operation not disposed after quit? I need to take more time to investigate it.

paring-chan commented 1 day ago

I guess it's an issue from electron. The main process actually exits(but I think it can be just an wrapper), but (maybe) child processes become zombie(actually the window doesn't disappear), but I think the task freezing is another issue

I'll let you know if the freeze on exit disappears with latest electron(I can use the launcher with latest electron in nixpkgs)